search

pulumi / pulumi-awsx

AWS infrastructure best practices in component form!
https://www.pulumi.com/docs/guides/crosswalk/aws/
Apache License 2.0
227 stars 104 forks source link

Elastic IPs are missing tags (default and explicit) #983

Open rodrigobrim opened 1 year ago

rodrigobrim commented 1 year ago

What happened?

It doesn't matter if default or explicit tags are set on ec2.NewVpc call, the nat gateways elastic IPs are created with no one.

Expected Behavior

Tags set on ec2.VpcArgs.Tags or default tags should be respected for all child resources.

Steps to reproduce

Set the default tags, create a VPC with nat gateways, then inspect the mentioned resource tags.

Output of pulumi about

CLI
Version 3.53.0 Go Version go1.19.5 Go Compiler gc

Plugins NAME VERSION go unknown

Host
OS ubuntu Version 22.04 Arch x86_64

This project is written in go: executable='/usr/local/go/bin/go' version='go version go1.19.4 linux/amd64'

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

squaremo commented 1 year ago

Thanks for pointing this out :star: Related (but not the same): https://github.com/pulumi/pulumi-awsx/pull/974