pulumi / pulumi-az-pipelines-task

Azure Pipelines task extension for running Pulumi apps.
https://marketplace.visualstudio.com/publishers/pulumi
Apache License 2.0
27 stars 19 forks source link

Support comments #110

Open jaxxstorm opened 2 years ago

jaxxstorm commented 2 years ago

Is your feature request related to a problem? Please describe. A customer has created a custom integration that will comment back on the ADO task output to show what is changing, very similar to the github action integration

Describe the solution you'd like When Pulumi preview or up runs, any changes should be posted back to the PR or the triggering pipeline

Describe alternatives you've considered Similar to GitHub actions

jaxxstorm commented 2 years ago

This seems to be the same as #87

pulumi-bot commented 2 years ago

Cannot close issue without required labels: kind/, resolution/

praneetloke commented 2 years ago

This should be possible using the DevOps REST API to create comment threads in PRs. There's a Node.js client SDK for interacting with the API.

Additional refs https://docs.microsoft.com/en-us/rest/api/azure/devops/git/pull-request-threads/create?view=azure-devops-rest-6.0&tabs=HTTP https://docs.microsoft.com/en-us/rest/api/azure/devops/git/pull-request-thread-comments/create?view=azure-devops-rest-6.0&tabs=HTTP
sloncho commented 2 years ago

would this help? https://marketplace.visualstudio.com/items?itemName=tylermurry.pr-auto-comment If the pulumi task outputs the result in json file or something

dblair-cet commented 2 years ago

Would it be possible to skip the deletion of the temporary pulumi-out.log file or make deleting it configurable? If I could grab that file I could pipe its contents into the github comment task or use it for other purposes. This would be very helpful especially since the Pulumi GitHub App is not working!

Specifically, removing or making optional line 175 of pulumi.ts

praneetloke commented 2 years ago

This would be very helpful especially since the Pulumi GitHub App is not working!

@dblair-cet what's not working specifically in the GH App?