search

pulumi / pulumi-az-pipelines-task

Azure Pipelines task extension for running Pulumi apps.
https://marketplace.visualstudio.com/publishers/pulumi
Apache License 2.0
27 stars 19 forks source link

Task fails when using threaded comments and comment thread has already been resolved #134

Open imdex-brett-debeer opened 1 year ago

imdex-brett-debeer commented 1 year ago

Describe the bug Task fails when using threaded comments and comment thread has already been resolved. Error message is produced is below.

##[error]TypeError: Cannot read property '$value' of undefined

To Reproduce Steps to reproduce the behavior:

  1. Create a pipeline that uses the task to preview changes with threaded PR comments
  2. Create a PR
  3. Run pipeline
  4. Resolve comments
  5. Run pipeline
  6. See error

Expected behavior Pipeline task should create a new comment is previous comment has been resolved.

Additional context Issue does not occur when using threaded PR comments.

Error is likely due to source being undefined on line 198 of buildAndReleaseTask/prComment.ts

Frassle commented 1 year ago

Error is likely due to source being undefined on line 198 of

Looks like it. Probably ok for the filter to just check if that's undef and filter out in that case.

RobbieMcKinstry commented 1 year ago

^Yes. We've encountered similar errors in the GitHub Action.

aureq commented 5 months ago

@Frassle Have we been able to progress on this since the error may have been identified?

Frassle commented 5 months ago

Not yet, mostly just been a case of no one having time to pick up anything from this codebase.