Add Support for AWS Service Connections

pulumi / pulumi-az-pipelines-task

Azure Pipelines task extension for running Pulumi apps.

https://marketplace.visualstudio.com/publishers/pulumi

Apache License 2.0

27 stars 19 forks source link

Add Support for AWS Service Connections #149

Open zbuchheit opened 1 year ago

zbuchheit commented 1 year ago

Thank you for contributing! Before submitting your PR, can you please confirm that you have done the following?

[x] If you changed the values of the properties name, publisher, and galleryFlags in the vss-extension.json file, you have reverted them.
[x] If you changed the values of the properties id, name, author, you have reverted them.
[x] I have reverted any changes to the version number components in both vss-extension.json and task.json, OR I didn't change them.

Related to: #80

zbuchheit commented 1 year ago

LGTM otherwise

In the future, you can just clone this repo directly and create a branch for the PR, rather than from your fork.

I was following the Contributing doc but noted for next time! Thanks! Also, I noticed we do some integration testing, we will need to create an AWS service connection in the ADO org we run the test in if we want to add additional integration tests to cover this feature.

zbuchheit commented 11 months ago

@justinvp I added the new awsServiceConnection input to the integration azure pipeline file on 137ddd7. Someone will need to add an aws service connection to the test organization in Azure Devops for the integration test to reference. I do not have access to that. The service connection is provided via the The AWS Toolkit for Azure Devops.