Open zbuchheit opened 9 months ago
LGTM otherwise
In the future, you can just clone this repo directly and create a branch for the PR, rather than from your fork.
I was following the Contributing doc but noted for next time! Thanks! Also, I noticed we do some integration testing, we will need to create an AWS service connection in the ADO org we run the test in if we want to add additional integration tests to cover this feature.
@justinvp I added the new awsServiceConnection input to the integration azure pipeline file on 137ddd7. Someone will need to add an aws service connection to the test organization in Azure Devops for the integration test to reference. I do not have access to that. The service connection is provided via the The AWS Toolkit for Azure Devops.
Thank you for contributing! Before submitting your PR, can you please confirm that you have done the following?
name
,publisher
, andgalleryFlags
in thevss-extension.json
file, you have reverted them.id
,name
,author
, you have reverted them.vss-extension.json
andtask.json
, OR I didn't change them.Related to: #80