search

pulumi / pulumi-az-pipelines-task

Azure Pipelines task extension for running Pulumi apps.
https://marketplace.visualstudio.com/publishers/pulumi
Apache License 2.0
27 stars 19 forks source link

Migrate task to Node10 runtime #85

Closed praneetloke closed 3 years ago

praneetloke commented 3 years ago

Fixes #84.

The task thankfully does not depend on anything specific to legacy Node versions. To provide some background, when the task was authored it's just that the tutorials for creating a custom task extension used the execution target as Node instead of Node10. I am not even sure if Azure Pipelines had support for Node10+ execution targets back when this was originally authored.

I followed the guide from https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/migrateNode10.md.

praneetloke commented 3 years ago

Do we really want to target Node10 here? I thought it was deprecated

Note that despite the name indicating that it is Node10 I don't think (not 100% sure) that it literally targets Node 10.x or if it is Node 10+. Just so we are on the same page -- this does not affect the the Pulumi program runtime. It is the execution target for the task extension itself and how the Azure Pipelines service executes it. We have no choice here but to change the task's manifest using the migration instructions they have provided. As per the linked issue, a warning is printed today every time the task extension executes. (I see it in my personal pipelines too.)

[warning]This task uses Node 6 execution handler, which will be deprecated soon. If you are the developer of the task - please consider the migration guideline to Node 10 handler - https://aka.ms/migrateTaskNode10. If you are the user - feel free to reach out to the owners of this task to proceed on migration.

Here's the schema for task.json: https://github.com/Microsoft/azure-pipelines-task-lib/blob/master/tasks.schema.json#L407-L418