pulumi / pulumi-azure-native

Azure Native Provider
Apache License 2.0
127 stars 34 forks source link

WebAppApplicationSettings does not show difference correctly on preview/up #721

Open WillooWisp opened 3 years ago

WillooWisp commented 3 years ago

Adding a new setting to the list of app settings and performing an up shows as value even though I have specified "1234" as a string. The app setting is however added correctly in Azure for the web app with "1234" as value when up is finished.

[urn=urn:pulumi:demo12349866::platform::azure-native:web:WebAppApplicationSettings::waas-demo12349866] [provider: urn:pulumi:demo12349866::platform::pulumi:providers:azure-native::default_0_7_1::a1c5010c-56be-428d-af90-622635703574 => urn:pulumi:demo12349866::platform::pulumi:providers:azure-native::default_0_8_0::output] ~ properties: {

Changing the value from "1234" to "12345" and performing an up does not show this change either, just a change to properties as a set. But as in the case above the change really happens and the web app gets a Test app setting changed to "12345".

~ azure-native:web:WebAppApplicationSettings: (update) [id=/subscriptions/3b6174e5-9dc2-479c-b5c9-9981c64e178e/resourceGroups/demo12349866/providers/Microsoft.Web/sites/demo12349866/config/appsettings] [urn=urn:pulumi:demo12349866::platform::azure-native:web:WebAppApplicationSettings::waas-demo12349866] [provider=urn:pulumi:demo12349866::platform::pulumi:providers:azure-native::default_0_8_0::67e2b176-8b77-480e-8b6e-8d7bb449a02b] ~ properties: { } Resources: ~ 1 to update

mikhailshilkov commented 3 years ago

This likely the same as https://github.com/pulumi/pulumi-azure-native/issues/468 (or, rather, it has the same cause and solution)

WillooWisp commented 3 years ago

Okay, the tags problems was not a big issue, but this is, since you really cannot trust what will happen during the up, since the diff is not complete. It has not been prioritized before I guess, but what do you think of this now? Can we expect a fix anytime soon?

WillooWisp commented 3 years ago

@mikhailshilkov any news in Pulumi 3.0, that might help fixing this?

mikhailshilkov commented 3 years ago

No, I am not aware of any related changes

WillooWisp commented 3 years ago

@mikhailshilkov Any plans on fixing correct diffs for untyped dictionaries so that it will be possible to see what have changed for WebAppApplicationSettings for example?

mikhailshilkov commented 3 years ago

@WillooWisp No concrete plans right now