search

pulumi / pulumi-azuread

A Microsoft Azure Active Directory (Azure AD) Pulumi resource package, providing multi-language access to Azure AD
Apache License 2.0
17 stars 8 forks source link

metadata_host is marked as required upstream but actually isn't #1233

Closed thomas11 closed 1 month ago

thomas11 commented 1 month ago

Resolves #362 - users of this provider need to specify this config even if the default is fine.

The upstream provider has this property marked as required, but that works differently in Terraform: since there's also a DefaultFunc configured, the function's return value will be used if the user doesn't specify a value, and the function itself returns a default of "". So a value is guaranteed, even if it's the empty string.

In Pulumi, "required" means needs to be configured by the user. Therefore, we mark this property as optional to get the same behavior as upstream.

github-actions[bot] commented 1 month ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

thomas11 commented 1 month ago

Could you file a bug in the bridge? It sounds like we should mark this field as optional in Pulumi.

Sure: https://github.com/pulumi/pulumi-terraform-bridge/issues/2204

pulumi-bot commented 1 month ago

This PR has been shipped in release v5.53.3.