search

pulumi / pulumi-cloud-requests

Welcome to the public issue tracker for Pulumi Cloud (app.pulumi.com)! Feature requests and bug reports welcome!
10 stars 4 forks source link

[feat] Option to Enable/Disable 'No Changes' Comments by Pulumi GitHub App/Bot #308

Open zbuchheit opened 1 year ago

zbuchheit commented 1 year ago

Affected feature

Pulumi Github App/Bot

Current Behavior:

At present, if an action results in no changes, the Pulumi GitHub App/Bot does not post a comment on the Pull Request. This lack of notification can lead to confusion as users might expect a comment noting the absence of changes.

Suggested Enhancement:

To improve user experience, add a feature to enable or disable comments from the Pulumi GitHub App/Bot for actions with no changes. This setting will allow users to choose according to their preference. Some users may want to receive comments for no changes, while others may prefer not to receive such notifications.

zbuchheit commented 1 year ago

A customer left feedback that specifically an option to have "comment even with no changes" would be desired

mikocot commented 1 year ago

Having that option is one thing, but even without it we believe there is a scenario where comment should be added regardless of configuration. This is when any comment for particular stack had been added previously in PR. So currently:

  1. we create a PR with unwanted changes to infrastructure => a comment is added indicating those changes (good)
  2. we remove those changes and rerun builds
  3. the old comment indicating changes is still there, cause it was not updated with one showing 'no changes' (bad)

I fully understand that in many cases adding an empty comment showing no changes makes no sense, but if there was a previous comment, the update should be always added IMO

EvanBoyle commented 1 year ago

Another note is that for scenarios with PR checks they don't show up if there are no pulumi changes which is a little inconvenient for branch protection rules. https://pulumi-community.slack.com/archives/C048NVDH6DV/p1697592426894389