search

pulumi / pulumi-cloud-requests

Welcome to the public issue tracker for Pulumi Cloud (app.pulumi.com)! Feature requests and bug reports welcome!
10 stars 4 forks source link

Pulumi GitHub App edit comments rather than minimizing. #450

Open zevisert opened 2 months ago

zevisert commented 2 months ago

Note that comments will be minimized, not deleted. This way there is still historical context if you need it for debugging.

@blampe To maintain historical context, but minimize noise, the Pulumi app could update old comments instead of making new ones. This would save it from taking up ever-more space on PRs (which is still an issue even with it minimizing the old comments). This would also prevent it from spamming notifications as each new comment produces a notification, but updating a comment does not. All edits to the comments can be viewed, so there is no loss of historical context.

This approach of updating old comments is used by other similar tools, such as codecov.

Originally posted by @WillDaSilva in #59

It would be really nice to have this, especially for the notification aspect. In some of our busy PRs, we have to scroll past many minimized comments as the PR get updated. In one repository that previews the deployment of several stacks for each commit, this gets extremely annoying.

Image

grantjoy commented 1 month ago

Big +1! We are drowning in (minimized) comments!

grantjoy commented 1 month ago

Image 😢