search

pulumi / pulumi-cloudflare

Pulumi's Cloudflare package, providing multi-language infrastructure as code for Cloudflare
Apache License 2.0
104 stars 14 forks source link

Add type for placement mode #916

Closed hckhanh closed 2 months ago

hckhanh commented 2 months ago

With the same idea with #915

github-actions[bot] commented 2 months ago

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] commented 2 months ago

Hello and thank you for your pull request! :heart: :sparkles: It looks like you're directly modifying files in the language SDKs, many of which are autogenerated. Be sure any files you're editing do not begin with a code generation warning. For generated files, you will need to make changes in resources.go instead, and generate the code.

guineveresaenger commented 2 months ago

Same story as #915; this is a docs issue, where the documentation should tell you which strings are valid input. Thank you for making us aware!