pulumi / pulumi-confluentcloud

A Confluent Pulumi resource package, providing multi-language access to Confluent
Apache License 2.0
8 stars 3 forks source link

Routine bridge updates causes tests to fail with missing "resource_name" #248

Closed t0yv0 closed 12 months ago

t0yv0 commented 1 year ago

What happened?

https://github.com/pulumi/pulumi-confluentcloud/pull/247

Need to investigate if this is a regression.

Example

N/A

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

mikhailshilkov commented 1 year ago

@t0yv0 Are you looking into this or should I assign @iwahbe (ops)?

t0yv0 commented 1 year ago

Appreciate ops help.

iwahbe commented 1 year ago

The test was always broken, the bridge update caused it to be enforced. The relevant call was:

https://github.com/pulumi/pulumi-confluentcloud/blob/93707629eca3decc95713467800c1d4338947cc6/examples/basic-kafka-acls/py/__main__.py#L95

This was a typo:

-                              resource_name_=resource_name,
+                              resource_name=resource_name,
t0yv0 commented 1 year ago

Thanks for looking into this. Good news!

justinvp commented 1 year ago

This was a typo:

Actually, it wasn't a typo. More details here: https://github.com/pulumi/pulumi-confluentcloud/pull/247#issuecomment-1783717144

The example should go back to:

resource_name_=resource_name,

And the issue will be addressed after upgrading codegen to v3.91.1 of Pulumi, which reverts the change that introduced _configure in the first place.

iwahbe commented 12 months ago

I assumed it was a typo since _configure was checking for "resource_name" and not "resource_name_". We have upgraded to v3.91.1 as part of https://github.com/pulumi/pulumi-confluentcloud/pull/255.

pulumi-bot commented 12 months ago

Cannot close issue:

Please fix these problems and try again.