search

pulumi / pulumi-docker-build

A Pulumi native provider for Docker
Apache License 2.0
6 stars 2 forks source link

Fix weekly-pulumi-update #232

Closed rquitales closed 2 months ago

rquitales commented 2 months ago

Fixes: #212

This PR follows the weekly-pulumi-update CI workflow steps to update our pulumi/pulumi dependency, with manual intervention to resolve tooling update conflicts. Before generating the SDKs, it's necessary to update the language tools and otel packages to ensure compatibility with the latest changes.

Additional command executed for the manual updates:

TOOLS=(
    "github.com/pulumi/pulumi/sdk/go/pulumi-language-go/v3"
    "github.com/pulumi/pulumi/sdk/nodejs/cmd/pulumi-language-nodejs/v3"
    "github.com/pulumi/pulumi/sdk/python/cmd/pulumi-language-python/v3"
    "go.opentelemetry.io/otel/exporters/otlp/otlptrace"
)

for TOOL in "${TOOLS[@]}"; do
    go get -u $TOOL
    go mod tidy
done
rquitales commented 2 months ago

@blampe Do you think it makes sense to also add a step within weekly-pulumi-update to also update the upstream language tools?

github-actions[bot] commented 2 months ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (5d7ff1e) to head (110eccf). Report is 1 commits behind head on main.

Additional details and impacted files ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/pulumi/pulumi-docker-build/pull/232?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pulumi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pulumi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/pulumi/pulumi-docker-build/pull/232?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pulumi). Last update [5d7ff1e...110eccf](https://app.codecov.io/gh/pulumi/pulumi-docker-build/pull/232?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pulumi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pulumi).
blampe commented 2 months ago

@blampe Do you think it makes sense to also add a step within weekly-pulumi-update to also update the upstream language tools?

Nah. My hack with Renovate + mise made this a lot more straightforward -- to the point where we don't need weekly-pulumi-update anymore, because we can automatically bump any pulumi dependency (not just pu/pu). I'll chip away at that some more after the test sharding stuff goes in.