search

pulumi / pulumi-docker

A Docker Pulumi resource package, providing multi-language access to Docker resources and building images.
81 stars 14 forks source link

Example for container is missing code blocks #1201

Open andrzejressel opened 3 weeks ago

andrzejressel commented 3 weeks ago

Describe what happened

Example for container resource looks weird, because it's missing code blocks (for #!/bin/bash and terraform part): https://www.pulumi.com/registry/packages/docker/api-docs/container/#example

Terraform registry is rendering it just fine https://registry.terraform.io/providers/kreuzwerker/docker/latest/docs/resources/container#import

Sample program

N/A

Log output

N/A

Affected Resource(s)

container

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

andrzejressel commented 2 weeks ago

This is weird - I've copied tf markdown to pulumi-terraform-bridge so I can run tests on it and it seems to be converting fine. But it is still broken in generation: https://github.com/pulumi/pulumi-docker/blob/master/sdk/java/src/main/java/com/pulumi/docker/Container.java#L97

andrzejressel commented 2 weeks ago

I believe it's due to the very strict rules regarding import parsing. Now i see 2 issues:

  1. !#/bin/bash is spilling outside of code block
  2. Non shell code blocks are ignored