search

pulumi / pulumi-dotnet

.NET support for Pulumi
Apache License 2.0
27 stars 25 forks source link

Fix publishing SDKs to include required attribute for Pulumi.Automation #393

Closed JasonWhall closed 1 day ago

JasonWhall commented 4 days ago

Currently when publishing the Pulumi.Automation SDK there is an expected property PulumiSdkVersion which should be set when building the project

This property is set during buildSdk and testPulumiAutomationSdk but not the publishing targets which provide the resulting nuget package.

This means when a consumer references the Automation Api nuget package they have a version that does not have the required property set causing LocalPulumiCommand.Install to fail.

Refactored the F# code to ensure the version is set during publish as well

Fixes #392

Frassle commented 3 days ago

I don't think the test failures here are due to this PR, seeing it elsewhere as well. Looking into it.

Frassle commented 1 day ago

Hey @JasonWhall if you rebase this on latest main I think we should be able to get the tests passing and get this merged in.

JasonWhall commented 1 day ago

@Frassle - Thanks! Re-based

pulumi-bot commented 1 day ago

This PR has been shipped in release v3.69.0.