search

pulumi / pulumi-eks

A Pulumi component for easily creating and managing an Amazon EKS Cluster
https://www.pulumi.com/registry/packages/eks/
Apache License 2.0
168 stars 77 forks source link

Guarantee JSON output of awscli to generate kubeconfig #1136

Closed sublee closed 2 months ago

sublee commented 2 months ago

Proposed changes

Specify --output json args of the aws command in generated kubeconfig files.

The default output format of aws might be configured in ~/.aws/config by the user. Hence, the output is not guaranteed to be in JSON format without the --output argument.

github-actions[bot] commented 2 months ago

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

rquitales commented 2 months ago

Thanks for the PR @sublee! /run-acceptance-tests

rquitales commented 2 months ago

/run-acceptance-tests

pulumi-bot commented 2 months ago

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/8900164473

rquitales commented 2 months ago

Merging despite the failing upgrade test (due to changing AMIs).