search

pulumi / pulumi-eks

A Pulumi component for easily creating and managing an Amazon EKS Cluster
https://www.pulumi.com/registry/packages/eks/
Apache License 2.0
168 stars 76 forks source link

Handle arg inputs as potential Pulumi Outputs #1173

Closed rquitales closed 3 weeks ago

rquitales commented 1 month ago

Proposed changes

This PR wraps all arg inputs that call .toString() with pulumi.all incase a pulumi.Output value is supplied instead of a pulumi.Input or plain type. As this is a MLC component, we needsto correctly deal with output values as we can't just assume that the engine sends Input as a plain string.

Tests done:

Related issues (optional)

Fixes: #1160 Fixes: #1172

github-actions[bot] commented 1 month ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

t0yv0 commented 1 month ago

Do we understand why the tests are failing?

github-actions[bot] commented 1 month ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

github-actions[bot] commented 3 weeks ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

t0yv0 commented 3 weeks ago

I don't think there's an easy fix

There is a fix but it would make the code read a little ugly. 

const os = new OutputSequencer()

os.sequence(output1);
os.sequence(output2);

return {
   output1: output1,
   output2: output2,
}

I think based on the latest comment we're fine here though. Thank you!

github-actions[bot] commented 3 weeks ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.