pulumi / pulumi-eks

A Pulumi component for easily creating and managing an Amazon EKS Cluster
https://www.pulumi.com/registry/packages/eks/
Apache License 2.0
168 stars 76 forks source link

eks.ManagedNodeGroup: launchTemplate is ignored #1193

Closed dstockhammer closed 2 weeks ago

dstockhammer commented 2 weeks ago

What happened?

It looks like version 2.5.0 introduced a regression that results in the launchTemplate arg to eks.ManagedNodeGroup being ignored. The example below used to work fine up until and including version 2.4.0, but breaks from version 2.5.0 onwards. The launchTemplate arg is ignored and thus removed from the resource as shown in the output.

I believe the regression is caused by a change in https://github.com/pulumi/pulumi-eks/pull/1131; I'll add a comment to that PR.

Example

new eks.ManagedNodeGroup("nodegroup-static", {
  cluster: cluster,
  amiType: "AL2_ARM_64",
  instanceTypes: ["m7g.xlarge"],
  subnetIds: vpc.privateSubnetIds,
  nodeRole: cluster.instanceRoles[0],
  launchTemplate: {  // <-- this is ignored
    id: launchTemplate.id,
    version: pulumi.interpolate`${launchTemplate.latestVersion}`,
  },
});

Output of pulumi about

CLI          
Version      3.119.0
Go Version   go1.22.4
Go Compiler  gc

Plugins
KIND      NAME        VERSION
resource  aws         6.39.1
resource  awsx        2.11.0
resource  docker      4.5.4
resource  docker      3.6.1
resource  eks         2.5.0
resource  kubernetes  4.13.1
language  nodejs      unknown

Dependencies:
NAME                VERSION
@pulumi/awsx        2.11.0
@pulumi/eks         2.5.0
@pulumi/kubernetes  4.13.1
@pulumi/pulumi      3.119.0
@types/node         20.14.2
ts-node             10.9.2
yaml                2.4.5
@pulumi/aws         6.39.1

Additional context

pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:prod::base::pulumi:pulumi:Stack::base-prod]
        ~ aws:eks/nodeGroup:NodeGroup: (update)
            [id=xxx-prod:nodegroup-static-prod20240304172943231900000001]
            [urn=urn:pulumi:prod::base::eks:index:ManagedNodeGroup$aws:eks/nodeGroup:NodeGroup::nodegroup-static]
            [provider=urn:pulumi:prod::base::pulumi:providers:aws::default_6_39_1::6de6c1e0-804e-479e-b4d1-e06c3f24e08b]
          - launchTemplate: {
              - id     : "lt-redacted"
              - name   : "nodegroup-static-prod20240228152929421500000001"
              - version: "5"
            }
          - launchTemplate: {
              - id     : "lt-redacted"
              - name   : "nodegroup-static-prod20240228152929421500000001"
              - version: "5"
            }

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

flostadler commented 2 weeks ago

Hey @dstockhammer. Sorry you're running into this. I was able to reproduce it locally and started to work on a fix now.

flostadler commented 2 weeks ago

@dstockhammer This is fixed in v2.7.1 now