search

pulumi / pulumi-eks

A Pulumi component for easily creating and managing an Amazon EKS Cluster
https://www.pulumi.com/registry/packages/eks/
Apache License 2.0
171 stars 80 forks source link

Fix ManagedNodeGroup for cluster with API authentication mode #1199

Closed flostadler closed 3 months ago

flostadler commented 3 months ago

Proposed changes

Adding a ManagedNodeGroup to a cluster with API authentication mode fails because there's verification logic that expects the role for the EC2 instances to be present in the instanceRoles list of the cluster. If the necessary authentication configuration for the EC2 instances was added as access entries, this verification will fail.

This change fixes that by excluding this check in case the cluster supports access entries.

Related issues (optional)

fixes #1197

github-actions[bot] commented 3 months ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.