Remove ClusterInternal reference in typescript provider

pulumi / pulumi-eks

A Pulumi component for easily creating and managing an Amazon EKS Cluster

https://www.pulumi.com/registry/packages/eks/

Apache License 2.0

171 stars 80 forks source link

Remove ClusterInternal reference in typescript provider #1209

Closed rquitales closed 3 months ago

rquitales commented 3 months ago

Proposed changes

The ClusterInternal type is a internal TS type. When users attempt to transpile their typescript programs to javascript, they'll encounter a symbol not found error, since internal types won't be exposed in the type annotations file. ClusterInternal isn't necessary since its used for MLC codegen, so this will not be a breaking change.

Testing:

Updated existing typescript test to also run the build step

Related issues (optional)

Fixes: #1205

github-actions[bot] commented 3 months ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

github-actions[bot] commented 3 months ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.