pulumi / pulumi-eks

A Pulumi component for easily creating and managing an Amazon EKS Cluster
https://www.pulumi.com/registry/packages/eks/
Apache License 2.0
171 stars 79 forks source link

Allow all arguments in NodeGroupV2 to be `pulumi.Input` #1274

Open Makeshift opened 2 months ago

Makeshift commented 2 months ago

Hello!

Issue details

I ran into an issue today when trying to create a NodeGroup whose labels and taints were not known initially and were therefore pulumi.Output's. Unfortunately, the labels and taints args (and a few more) in the NodeGroupV2 component are treated and typed as plain values, so it isn't possible to use potentially-unresolved values when creating them.

Please add support for labels and taints to be resolved from pulumi.Output.

Affected area/feature

This component.

Makeshift commented 2 months ago

As an aside, I did try to do this myself so I could PR it, but unfortunately hit some serialisation issues that I'm not familiar enough with to debug effectively.

t0yv0 commented 2 months ago

Thank you for trying to send a PR here! Unfortunately it's a little more involved. Our team will have a look at this when planning the next major release, possibly combined with https://github.com/pulumi/pulumi-eks/issues/603

t0yv0 commented 2 months ago

CC @flostadler