eks.NewCluster - Children's resources are not tagged

rodrigobrim commented 1 year ago

What happened?

It doesn't matter if default or explicit tags are set on eks.NewCluster call, the following resources are created with no tags (the list is not limited to it):

Node volumes
Network interfaces
One security group (with the description: EKS created security group applied to ENI that is attached to EKS Control Plane master nodes, as well as any managed workloads)

Expected Behavior

Tags set on eks.ClusterArgs.Tags or default tags should be respected for all child resources.

Steps to reproduce

Set the default tags, create an EKS cluster, then inspect the mentioned resource tags.

Output of `pulumi about`

Go Compiler  gc

Plugins
NAME  VERSION
go    unknown

Host     
OS       ubuntu
Version  22.04
Arch     x86_64

This project is written in go: executable='/usr/local/go/bin/go' version='go version go1.19.4 linux/amd64'

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

squaremo commented 1 year ago

t0yv0 commented 2 months ago

There's a recent quickfix for https://github.com/pulumi/pulumi-eks/pull/1359/files but the problem remains open in general.

With the https://www.pulumi.com/docs/concepts/options/transforms/ option a workaround should be possible to implement tagging for all child AWS resources. This is not the easiest option to use however so leaving this issue open for now. Please keep upvoting to help us prioritize.

t0yv0 commented 2 months ago

@flostadler points out there's some extra difficulty here for resources not directly created by Pulumi.

pulumi / pulumi-eks