search

pulumi / pulumi-gcp

A Google Cloud Platform (GCP) Pulumi resource package, providing multi-language access to GCP
Apache License 2.0
182 stars 52 forks source link

Remove-duplicative-resource-token.patch #1193

Open iwahbe opened 1 year ago

iwahbe commented 1 year ago

This patch removes some duplicated properties from the plugin sdk version of the terraform provider.

We could switch pf/tfbridge.MuxShimWithDisjointgPF to pf/tfbridge.MuxShimWithPF to allow us to remove the deletes. Unfortunelty, this brings up name conflicts since the provider translates iam as "Iam" or "IAM".

Tests

NA

Recommendation

Remove the patch before the next major version.

iwahbe commented 12 months ago

I spent some time fighting with this, and it's surprisingly difficult. We might want to punt and leave it in for the next release.

t0yv0 commented 11 months ago

Related: https://github.com/pulumi/pulumi-gcp/pull/1180

I'd appreciate more detail or perhaps an expanded issue here for 1180 and why "Iam" or "IAM" is in effect wrt pf/tfbridge.MuxShimWithDisjointgPF to pf/tfbridge.MuxShimWithPF.

Looking at 1180, I'm worried that arbitrary changes to tokens are not releasable, ever, due to the large blast radius covering things like example generation, pulumi convert, and possibly links in registry? The conservative option would be to try to keep tokens we've picked historically, even if they're suspect. Perhaps I can be bargained down to only keeping that for top-100 resources and do not apply the same rigor to the long tail.

t0yv0 commented 11 months ago

Likely a no-op for GCP 7.0 given timelines but can revisit later.

guineveresaenger commented 3 weeks ago

It turns out that removing this patch is not as previously thought a token mapping bug, but more likely a bug in resource generation.