pulumi / pulumi-gcp

A Google Cloud Platform (GCP) Pulumi resource package, providing multi-language access to GCP
Apache License 2.0
183 stars 53 forks source link

Incorrect statement about secrets being plain text #1195

Closed cnunciato closed 11 months ago

cnunciato commented 1 year ago

A community user noticed our GCP secretversion docs contain a statement inherited from the Terraform docs about secrets being stored in plain text:

image

In our case, however, this isn't true; secret data is stored in cyphertext. We should correct this so users aren't alarmed by it.

thomas11 commented 1 year ago

I think this will need to be done on the provider side, i.e., in pulumi-gcp. In pulumi-aws, also a bridged provider, we use a patch management system for that purpose.

mikhailshilkov commented 1 year ago

@thomas11 Your second link goes to our triage google doc, I think you may have wanted to link to another place?

lukehoban commented 1 year ago

Another user mentioned hitting this issue today. They believed the statement in the docs, and that led them to build a very complex and brittle workaround. Reminder of how important this is to fix.