v2.Metric does not consistently create or update appropriate log metric

quipcode commented 1 year ago

What happened?

When initially creating a new Metric resource we observed the resource is named as projects/[YOUR-PROJECT-ID]/metrics/[METRIC_NAME]. Any subsequent updates to said resources creates a new resource with the expected name of METRIC_NAME

Steps to reproduce

create a new Metric resource
run pulumi up
Navigate to GCP project's Logs-based metrics
observed the name of the created metric is of the format projects/[YOUR-PROJECT-ID]/metrics/[METRIC_NAME]
Make some changes to your Metric's resource
Update changes
observe a new logs-based metrics is created with the name METRIC_NAME

Expected Behavior

Metric's resource should be created with user specified resource name

Actual Behavior

Provider creates Metric's resource pre-pending the following relative path projects/[YOUR-PROJECT-ID]/metrics to the user specified resource name

Output of `pulumi about`

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

danielrbradley commented 1 year ago

Sorry for the inconvience @quipcode I've just dug into this and also encountered issues.

Using the following reproduction code:

const metric = new google.logging.v2.Metric("test", {
  filter: "resource.type=gae_app AND severity>=ERROR",
});

I actually ran into a slightly different issue.

The preview showed the planned output name as projects/***/metrics/test-30ec313
The deployment failed with object retrieval failure after successful create / read state: googleapi: Error 404: Metric test-be96141 does not exist
Note the name changed between preview and deployment which I wouldn't expect.
Using the console I can see the resource was in fact created successfully with the name test-be96141 (different to preview).
No partial resource was created in the state, so I'm unable to use pulumi refresh to retry the read.

Workaround

For now I'd recommend using the Google Cloud Classic provider:

const metric = new gcp.logging.Metric("test", {
  filter: "resource.type=gae_app AND severity>=ERROR",
  metricDescriptor: {
    metricKind: "DELTA",
    valueType: "INT64",
  },
});

I worked through the same workflow you described above and encountered no issues.

quipcode commented 1 year ago

Thank you will use the classic provider

pulumi / pulumi-google-native