pulumi / pulumi-java

Java support for Pulumi
Apache License 2.0
64 stars 19 forks source link

Invalid homepage and publisher #1366

Closed iwahbe closed 1 month ago

iwahbe commented 2 months ago

What happened?

We were diagnosing issues in package publishing. @mikhailshilkov found that Publishing to java requires that:

Ideally

Example

You can see an example of the needed changes here or here (where we needed to fix it).

It looks like we will also need fixes in:

Ideally, SDK generation will fix up the metadata so publishing will succeed. If publishing will fail, SDK generation should fail. It might not be possible to validate that the publisher will match but it is possible to validate that the homepage is valid.

Output of pulumi about

NA

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

justinvp commented 1 month ago

I think we could update this check to allow any case pulumi and www in the URL.

https://github.com/pulumi/pulumi-java/blob/0f614b60a861e9e2faa2f798036dda6fddb4dba4/pkg/codegen/java/templates_gradle.go#L126-L129