search

pulumi / pulumi-keycloak

A KeyCloak Pulumi resource package, providing multi-language access to KeyCloak
Apache License 2.0
35 stars 6 forks source link

Fix integration tests #454

Closed iwahbe closed 3 months ago

iwahbe commented 3 months ago

Fixes #432

This PR uses upstream's test setup to create a local testing keycloak harness. The deleted test files were copy and pasted from upstream originally, so nothing significant has changed in their contents, excepting that they were updated for keycloak's modern API paths.

github-actions[bot] commented 3 months ago

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

github-actions[bot] commented 3 months ago

Is README.md missing any configuration options?

additionalHeaders not found in Configuration section basePath not found in Configuration section redHatSso not found in Configuration section rootCaCertificate not found in Configuration section tlsInsecureSkipVerify not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

VenelinMartinov commented 3 months ago

Should we un-skip the tests too?

iwahbe commented 3 months ago

Should we un-skip the tests too?

Which tests are skipped? The tests run. The repo hasn't run a successful PR in the last month.

VenelinMartinov commented 3 months ago

Yeah, my bad, confused it with https://github.com/pulumi/pulumi-confluentcloud

Thanks for fixing!