When stack objects aren't deleted after tests, it can mean
resources created by the stack aren't tidied up;
the finalizer logic isn't well tested
the stack might interfere in annoying ways with other tests.
Previously, all stacks in the namespace were deleted as part of a top-level AfterEach; but because this tried to delete all stacks and wait until they'd been finalised, any rogue test case that didn't clean up properly and couldn't be finalised would cause some other test to time out.
The first commit here uses a similar idea, but fails the test suite if there are stacks left over at the very end. This highlighted a few problems, which I've also fixed here:
a couple of tests were deleting their backend directory before deleting the stack using it, and could fail to be finalized as a result;
lots of stacks had random names that didn't help with tracking down the test case
some stacks didn't even get deleted after their test case
Deleting a stack but not waiting for it to be finalized, within a test, could mean other tests were "contaminated" (usually only meaning they might take a bit longer, and get cross-talk in the logs, but still). I've made all test cases use a helper which waits for the finalizers to have run.
When stack objects aren't deleted after tests, it can mean
Previously, all stacks in the namespace were deleted as part of a top-level
AfterEach; but because this tried to delete all stacks and wait until they'd been finalised, any rogue test case that didn't clean up properly and couldn't be finalised would cause some other test to time out.The first commit here uses a similar idea, but fails the test suite if there are stacks left over at the very end. This highlighted a few problems, which I've also fixed here:
Deleting a stack but not waiting for it to be finalized, within a test, could mean other tests were "contaminated" (usually only meaning they might take a bit longer, and get cross-talk in the logs, but still). I've made all test cases use a helper which waits for the finalizers to have run.