feat: add helm chart - Githubissues

pulumi / pulumi-kubernetes-operator

A Kubernetes Operator that automates the deployment of Pulumi Stacks

Apache License 2.0

221 stars 55 forks source link

feat: add helm chart #379

Closed dirien closed 1 year ago

dirien commented 1 year ago

Proposed changes

Hi,

this PR adds the creation of Helm chart for the Pulumi operator.

The helm chart can be deployed in two ways:

Via Helm Repo (gh-page in this repo)
or signed OCI artefact (pushed to ghcr in this Organisation)

It uses:

Trivy to test for misconfiguration
chart-testing to lint the chart
chart-releaser to release the chart
cosign to sign the OCI helm chart

Related issues (optional)

dirien commented 1 year ago

I will schedule a call with @squaremo, to get this feedback. Thanks @viveklak!

squaremo commented 1 year ago

For the record, my feedback was

this makes installing the operator more accessible for a lot of people and orgs :tada:
can we have commits that do one thing, please
the changelog change is incongruent here, and might even break things, so elide that please
a follow-up would be to rewrite the deployment programs to use this Helm chart. This trades away the pulumi-kubernetes selling point of having types for Kubernetes objects -- but in the programs in question these are impenetrable struct literals, so that was a dubious benefit anyway.

stevesloka commented 1 year ago

Is this a dupe of https://github.com/pulumi/pulumi-kubernetes-operator/pull/261?

dirien commented 1 year ago

hi @squaremo,

I think I close this one and make one Chart in my own orga? Wdyt?

github-advanced-security[bot] commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.