search

pulumi / pulumi-kubernetes-operator

A Kubernetes Operator that automates the deployment of Pulumi Stacks
Apache License 2.0
214 stars 54 forks source link

prometheus monitoring fix - missing label #519

Closed Kris686 closed 3 months ago

Kris686 commented 8 months ago

Issue description

Pulumi kubernetes operator creates Service and ServiceMonitor objects for metrics by itself: https://github.com/pulumi/pulumi-kubernetes-operator/blob/7d9e693bc6e27f1e3881ce350cdf7fbde71b26be/cmd/manager/main.go#L186C31-L186C31

Service created for metrics requires name label added on pods.

Proposed changes

Added "name" label with {{ template "pulumi-kubernetes-operator.name" . }} value to pulumi-kubernetes-operator Deployment at ReplicaSet level.

impact/no-changelog-required

github-actions[bot] commented 8 months ago

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] commented 8 months ago

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Kris686 commented 8 months ago

@dirien done

Hey @Kris686,

thanks for the PR. Can you bump the minor version in the Chart.yaml and add artifacthub.io/changes: text?

github-actions[bot] commented 8 months ago

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] commented 3 months ago

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR