pulumi / pulumi-kubernetes-operator

A Kubernetes Operator that automates the deployment of Pulumi Stacks
Apache License 2.0
226 stars 54 forks source link

Git source #658

Closed blampe closed 2 months ago

blampe commented 2 months ago

Open questions:

Summary of changes so far:

Fixes #655

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 70.02967% with 101 lines in your changes missing coverage. Please review.

Project coverage is 26.17%. Comparing base (3f0a0b4) to head (be32ff2). Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
...r/internal/controller/auto/workspace_controller.go 28.30% 32 Missing and 6 partials :warning:
...tor/internal/controller/pulumi/stack_controller.go 34.21% 22 Missing and 3 partials :warning:
agent/cmd/init.go 69.44% 19 Missing and 3 partials :warning:
operator/internal/controller/pulumi/git.go 90.80% 12 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #658 +/- ## ========================================== + Coverage 20.66% 26.17% +5.50% ========================================== Files 25 25 Lines 3769 3947 +178 ========================================== + Hits 779 1033 +254 + Misses 2867 2772 -95 - Partials 123 142 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blampe commented 2 months ago

On the topic of SSH known hosts, what's the minimum we need to do? Keep in mind that the user can customize the pu/pu docker image.

I removed this TODO. Instead of accepting whatever the host's key is currently, we should encourage the user to customize the workspace with a custom mount containing the expected keys.