Closed blampe closed 2 months ago
Attention: Patch coverage is 70.02967%
with 101 lines
in your changes missing coverage. Please review.
Project coverage is 26.17%. Comparing base (
3f0a0b4
) to head (be32ff2
). Report is 1 commits behind head on v2.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
On the topic of SSH known hosts, what's the minimum we need to do? Keep in mind that the user can customize the pu/pu docker image.
I removed this TODO. Instead of accepting whatever the host's key is currently, we should encourage the user to customize the workspace with a custom mount containing the expected keys.
Open questions:
Summary of changes so far:
Removed code forgitAuthSecret
since it was marked deprecated in v1.Fixes #655