search

pulumi / pulumi-kubernetes-operator

A Kubernetes Operator that automates the deployment of Pulumi Stacks
Apache License 2.0
222 stars 55 forks source link

[v2] Stable envRefs #678

Closed blampe closed 4 weeks ago

blampe commented 1 month ago

Stack CRDs that include envRefs will currently thrash the workspace's underlying StatefulSet because map order is undefined.

This sorts the envRef keys ahead of time to keep the StatefulSet stable. As a result we're also able to turn on the E2E test in CI since it should now succeed reliably.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 33.25%. Comparing base (ab6c570) to head (be10198). Report is 1 commits behind head on v2.

Files with missing lines Patch % Lines
...tor/internal/controller/pulumi/stack_controller.go 20.00% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #678 +/- ## ======================================= Coverage 33.24% 33.25% ======================================= Files 25 25 Lines 3949 3951 +2 ======================================= + Hits 1313 1314 +1 - Misses 2474 2475 +1 Partials 162 162 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.