Closed rquitales closed 1 week ago
Attention: Patch coverage is 67.27273%
with 18 lines
in your changes missing coverage. Please review.
Project coverage is 50.22%. Comparing base (
2a67d4c
) to head (2bc40ee
). Report is 1 commits behind head on v2.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Proposed changes
This PR exposes the metrics service in our manifests and adds new unit tests to ensure the metrics logic is correct.
Technical changes
sigs.k8s.io/controller-runtime/pkg/metrics/filters
dependency to allow metrics to be secure by default (guidance from kubebuilder book/scaffold)updateStackCallback
functionstacks_reconciling
metricTesting
Note, e2e tests will be added in a followup PR.
Related issues (optional)
Closes: #576