pulumi / pulumi-kubernetes-operator

A Kubernetes Operator that automates the deployment of Pulumi Stacks
Apache License 2.0
222 stars 55 forks source link

Use sequential numbering for naming the Update object #722

Closed EronWright closed 4 days ago

EronWright commented 4 days ago

Proposed changes

Use a sequential numbering strategy for the stack update objects.

Before:

NAME                   WORKSPACE     PROGRESSING   FAILED   COMPLETE   URL
random-yaml-tf9hxngl   random-yaml                                     
random-yaml-tf9hxngl   random-yaml   True          False    False      
random-yaml-tf9hxngl   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4814
random-yaml-vqzmzxtr   random-yaml                                     
random-yaml-vqzmzxtr   random-yaml   True          False    False      
random-yaml-vqzmzxtr   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4815
random-yaml-m4wm7dzt   random-yaml                                     
random-yaml-m4wm7dzt   random-yaml   True          False    False      
random-yaml-m4wm7dzt   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4816

After:

NAME                      WORKSPACE     PROGRESSING   FAILED   COMPLETE   URL
random-yaml-1929cadf4a8   random-yaml                                     
random-yaml-1929cadf4a8   random-yaml   True          False    False      
random-yaml-1929cadf4a8   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4828
random-yaml-1929caf016f   random-yaml                                     
random-yaml-1929caf016f   random-yaml   True          False    False      
random-yaml-1929caf016f   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4829
random-yaml-1929cb00a8f   random-yaml                                     
random-yaml-1929cb00a8f   random-yaml   True          False    False      
random-yaml-1929cb00a8f   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4830

When you list the completed updates, they're now in order:

❯ kubectl get update
NAME                      WORKSPACE     PROGRESSING   FAILED   COMPLETE   URL
random-yaml-1929cadf4a8   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4828
random-yaml-1929caf016f   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4829
random-yaml-1929cb00a8f   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4830
random-yaml-1929cb11670   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4831
random-yaml-1929cb22165   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4832
random-yaml-1929cb32d64   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4833
random-yaml-1929cb43738   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4834
random-yaml-1929cb540cb   random-yaml   False         False    True       https://app.pulumi.com/eron-pulumi-corp/random/dev/updates/4835

Related issues (optional)

Closes #710

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.01%. Comparing base (6b9e71f) to head (94e4bcd). Report is 1 commits behind head on v2.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #722 +/- ## ======================================= Coverage 50.01% 50.01% ======================================= Files 30 30 Lines 4055 4055 ======================================= Hits 2028 2028 Misses 1843 1843 Partials 184 184 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.