search

pulumi / pulumi-kubernetes

A Pulumi resource provider for Kubernetes to manage API resources and workloads in running clusters
https://www.pulumi.com/docs/reference/clouds/kubernetes/
Apache License 2.0
396 stars 113 forks source link

Fix spurious diffs for updates in renderYaml mode #3030

Closed rquitales closed 1 month ago

rquitales commented 1 month ago

Proposed changes

Always store newInputs to avoid spurious diffs in renderYaml updates. Storing oldLive in state will result in the Pulumi state never updating after the initial create.

Testing: added a new step within the TestRenderYAML that exercises the update flow. This test fails without the changes in this PR.

Related issues (optional)

Fixes: #3026

github-actions[bot] commented 1 month ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 36.43%. Comparing base (41b0d90) to head (e18a0a9).

Files Patch % Lines
provider/pkg/provider/provider.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3030 +/- ## ======================================= Coverage 36.43% 36.43% ======================================= Files 70 70 Lines 9167 9167 ======================================= Hits 3340 3340 Misses 5497 5497 Partials 330 330 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.