search

pulumi / pulumi-kubernetes

A Pulumi resource provider for Kubernetes to manage API resources and workloads in running clusters
https://www.pulumi.com/docs/reference/clouds/kubernetes/
Apache License 2.0
397 stars 113 forks source link

Enable TypedDict input types for the Python SDK #3070

Closed julienp closed 5 days ago

julienp commented 6 days ago

Proposed changes

This PR requires pulumi/pulumi 3.121.0 and is stacked on top of https://github.com/pulumi/pulumi-kubernetes/pull/3066.

Enable TypedDict input types for the Python SDK. The only manual change is to set inputTypes flag in the python language features of the schema. This is done here https://github.com/pulumi/pulumi-kubernetes/commit/20314f5451f9fc7aec4fc8a1e0d649398159d3ec. This flag is currently opt in, but will default to classes-and-dicts in the future.

I ran make build afterwards.

Related issues (optional)

Epic https://github.com/pulumi/pulumi/issues/12689

julienp commented 6 days ago

How are tests run, are they triggered manually?

rquitales commented 5 days ago

How are tests run, are they triggered manually?

It should be automatic. I rebased this PR to latest change in master and that seems to have triggerred CI.

github-actions[bot] commented 5 days ago

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.76%. Comparing base (69b5ac6) to head (1b9e270).

Files Patch % Lines
provider/pkg/gen/schema.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3070 +/- ## ========================================== - Coverage 36.80% 36.76% -0.04% ========================================== Files 71 71 Lines 9269 9270 +1 ========================================== - Hits 3411 3408 -3 - Misses 5521 5524 +3 - Partials 337 338 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.