pulumi / pulumi-kubernetesx

Kubernetes for Everyone
Apache License 2.0
135 stars 16 forks source link

allow hyphens (-) when auto-naming the container #68

Open Iced-Sun opened 3 years ago

Iced-Sun commented 3 years ago

Affected feature

The generated container names are extracted by the regex /(.*\/|^)(?<image>\w+)(:(?<tag>.*))?/, which skips hyphens. Since most docker images use hyphens rather than underscores (e.g., cert-manager, external-dns, aws-load-banlance-controller), the regex just extracts the first word.

Is there any consideration that stops including hyphens?