search

pulumi / pulumi-kubernetesx

Kubernetes for Everyone
Apache License 2.0
135 stars 16 forks source link

Add support for metada in createService method #74

Closed Oyelowo closed 5 months ago

Oyelowo commented 2 years ago

Problem

createService method on Deployment class uses deployment name with randomised suffix by default and has no means of defining custom name or namespace for a service. Of course, this can be done with the kx.Service class but it would be nice to provide overriding options in createService method.

This also uses deployment metadata name as service name by default rather than the deployment resource id which provides some stability.

This closes https://github.com/pulumi/pulumi-kubernetesx/issues/52 and https://github.com/pulumi/pulumi-kubernetesx/issues/73

danielrbradley commented 2 years ago

Following an internal conversation, we might not be able to release this immeidately as this component isn't actively supported - meaning some of the release mechanism requires additional updates which we've not got capacity to replace. But if you're happy to leave this open then we'll endevour to incorporate this change at the point we can invest more into this component.

Thanks again for the contribution here, sorry we can't get this shipped out as fast as we'd like.

mjeffryes commented 5 months ago

Due to lack of tests in this repo and the age, we're not in a good position to move this PR forward so closing for now.