pulumi / pulumi-newrelic

An New Relic Pulumi resource package, providing multi-language access to New Relic
Apache License 2.0
14 stars 6 forks source link

Provider config variable `adminApiKey` is obsolete #484

Open jkodroff opened 12 months ago

jkodroff commented 12 months ago

What happened?

The Pulumi New Relic provider has a config option called adminApiKey. However, the upsteam Terraform provider has no such option (at least in the docs). I even went back a major version and did not see such an option in provider config.

I'm working on a New Relic workshop, and my code appears to work fine by only specifying accountId and apiKey, so this leads me to believe adminApiKey is obsolete. It's also very confusing because there is no description for what it's even supposed to represent: not on Installation and Configuration and not on the provider's API docs page.

Expected Behavior

n/a

Steps to reproduce

n/a

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

guineveresaenger commented 12 months ago

Hi @jkodroff - thank you for filing this! We'll clean this up as soon as we can.

I verified with the NewRelic documentation that this key is in fact deprecated since 2020.

https://docs.newrelic.com/docs/apis/intro-apis/new-relic-api-keys/#key-details --> "Other API Keys"

jkodroff commented 11 months ago

@guineveresaenger Note that the registry docs will also have to be updated for the Install and Config page: https://www.pulumi.com/registry/packages/newrelic/installation-configuration/