pulumi / pulumi-packet

A Pulumi provider for Packet
Apache License 2.0
8 stars 4 forks source link

Publish plugins to s3://get.pulumi.com, too. #71

Closed chrsmith closed 4 years ago

chrsmith commented 4 years ago

This PR updates the publish-plugin.sh script to copy built plugins to s3://get.pulumi.com in addition to s3://rel.pulumi.com. This is so that we can migrate to serving plugins via CDN on https://get.pulumi.com, instead of https://api.pulumi.com like we do today.

For more information about the overall effort, see this comment.

In addition, immediately before this code gets merged, I will also update the AWS access key used for this repo on:

The access key will be fore a different IAM User. This is part of https://github.com/pulumi/home/issues/708, and managing Pulumi's internal AWS access using Pulumi (and migrating off hand-crafted IAM permissions we set up in 2017).

I'm assuming that this repository doesn't need to create AWS resources, so I'll use an access key that only has permissions to upload resources and publish plugins but nothing else. I'll discover if this is correct when testing out the release path post-merge. (And can update Travis out of band.)

Next Steps

After this review gets the LGTM, the next steps are:

  1. Update the AWS credentials on Travis, GitHub
  2. Merge the PR. Wait for master to be green. Fix any problems associated with this PR.
  3. Celebrate I didn't break anything.