search

pulumi / pulumi-policy-aws

A policy pack of rules to enforce AWS best practices for security, reliability, cost, and more!
https://www.pulumi.com
Apache License 2.0
36 stars 7 forks source link

Use yarn.lock instead of package-lock.json #16

Closed chrsmith closed 4 years ago

chrsmith commented 4 years ago

The CI/CD setup I had was using yarn to get dependencies and things, but we had a package-lock.json checked into the repo. This PR corrects that.

chrsmith commented 4 years ago

Can't we just remove package-lock.json and add yarn.lock?

Yeah, in fact I'd be a little partial to that too. I am never sure if "npm is dead, long live yarn" or if "yarn is totally over, npm is cool again". (Or "wtf is yarn, just use nom".)

I'll make the change.

chrsmith commented 4 years ago

@justinvp PTAL, we should be totally into yarn for dependencies in the repo right now.

ekrengel commented 4 years ago

@sean1588 Another working agreement item -- we use yarn