Config: Update AWSGuard to use new config model - Githubissues

pulumi / pulumi-policy-aws

A policy pack of rules to enforce AWS best practices for security, reliability, cost, and more!

https://www.pulumi.com

Apache License 2.0

34 stars 6 forks source link

Config: Update AWSGuard to use new config model #48

Closed justinvp closed 4 years ago

justinvp commented 4 years ago

As part of this, consider consolidating any utility/helper code in @pulumi/policy to make it easy to author other Policy Packs in a similar manner.

Tasks:

In `pulumi/pulumi` (PR https://github.com/pulumi/pulumi/pull/4233):

[x] Add initialConfig property to AnalyzerInfo gRPC message which is returned when retrieving policy pack metadata. This initialConfig represents any config that was specified programmatically to the Policy Pack, for Policy Packs that support programmatic configuration like AWSGuard.
[x] Take initialConfig into account when reconciling default values and any externally specified config.

In `pulumi/pulumi-policy` (PR https://github.com/pulumi/pulumi-policy/pull/220):

[x] Add constructor arg to the PolicyPack class that accepts an initialConfig.
[x] Pass the initialConfig along with the GetAnalzyerInfo gRPC.

In `pulumi/pulumi-policy-aws`:

[x] Rewrite policies to use config system.
[x] Refactor how we register policies internally.
[x] Translate the config args that are passed to the AWSGuard constructor into a form acceptable for initialConfig, and pass the initialConfig to the base PolicyPack class's constructor (PolicyPack).
[x] Update unit tests to be able to specify config values that will be available to the policy handler's args.getConfig().