search

pulumi / pulumi-std

Standard library functions implemented as a native Pulumi provider to be consumed from all Pulumi supported languages
Apache License 2.0
2 stars 2 forks source link

Go publishing seems broken #34

Closed Frassle closed 6 months ago

Frassle commented 11 months ago

What happened?

Can't go get github.com/pulumi/pulumi-std/sdk/go/std v1.4.0:

$ go get github.com/pulumi/pulumi-std/sdk/go/std v1.4.0
go: downloading github.com/pulumi/pulumi-std v1.4.0
go: downloading github.com/pulumi/pulumi-std/sdk v0.0.0-20230607001730-519a13f355b7
go: unrecognized import path "v1.4.0": https fetch: Get "https://v1.4.0/?go-get=1": dial tcp: lookup v1.4.0 on 172.30.208.1:53: no such host

If you try and go get without a version you get a hash version:

$ go get github.com/pulumi/pulumi-std/sdk/go/std
go: added github.com/pulumi/pulumi-std/sdk v0.0.0-20230607001730-519a13f355b7

Expected Behavior

Go get to work for the released versions.

Steps to reproduce

See above, try and go get this sdk.

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

justinvp commented 9 months ago

I pushed the missing sdk/v1.4.0 tag, which should address this. Verified in a local test.

justinvp commented 9 months ago

Looks like it's more than just the missing tag. We seem to be generating a go.mod for pulumi-convert that has content like:

module migrate-terraform-pulumi

go 1.20

require (
    github.com/pulumi/pulumi/sdk/v3 v3.30.0
    github.com/pulumi/pulumi-aws/sdk/v6 v6.0.4
    github.com/pulumi/pulumi-std/sdk/go/std v1.4.0
)

The last require should be github.com/pulumi/pulumi-std/sdk v1.4.0

justinvp commented 6 months ago

Possibly an issue with baseImportPath in the schema definition. Not sure offhand if there is a way to set that from the Go Provider SDK.