pulumi / pulumi-synced-folder

A Pulumi component that synchronizes a local folder to Amazon S3, Azure Blob Storage, or Google Cloud Storage.
Apache License 2.0
3 stars 2 forks source link

synced-folder plugin not available through CDN #23

Closed lionello closed 8 months ago

lionello commented 1 year ago

What happened?

Tried to install using pulumi plugin install resource synced-folder v0.10.2 and failed with 403. Other plugins are available (unauth'ed) from that CloudFront URL, but synced-folder is not.

Expected Behavior

Expected to be able to download the plugins through the CDN URL (not just GitHub releases)

Steps to reproduce

Output of pulumi about

CLI          
Version      3.60.0
Go Version   go1.20.2
Go Compiler  gc

Host     
OS       darwin
Version  13.2.1
Arch     arm64

Backend        
Name           pulumi.com
URL            https://app.pulumi.com/lionello
User           lionello
Organizations  lionello

Pulumi locates its logs in /var/folders/wp/g4m6l2dx3f71wsy8j6l2wwdc0000gn/T/ by default

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Zaid-Ajaj commented 1 year ago

Hi there @lionello thank you for taking the time to file the issue 🙏

I have tried the command above: pulumi plugin install resource synced-folder v0.10.2 and it worked as expected. It could be that Github hit a sort of late limit at the time you tried to download the plugin from the releases. Can you give it another try to check whether it was something intermittent? Thank you!

lionello commented 1 year ago

I'm still getting the same error. Funnily enough it only happens with this plugin. Other plugins download fine? If it's just on my system, then I might have something weird here, so feel free to close.

cnunciato commented 1 year ago

I tried this as well and didn't have any issues, and the usual cause is indeed API rate-limiting on the GitHub end. @lionello does this repro when you have a GITHUB_TOKEN environment variable set with a valid GitHub access token?

jimjoes commented 1 year ago

I'm getting the same error. No change if I add a valid key to the GITHUB_TOKEN local env var, either.

nielskrijger commented 1 year ago

Having the same issue, specifically with this plugin. Github rate limits are exceeded and the fallback to get.pulumi.com fails.

Is there a reason why synced-folder is not available publicly?

The issue is also referenced here: https://github.com/pulumi/actions/issues/815

bensivo commented 1 year ago

I have also experienced this issue, in my case it was within a Gitlab CI pipeline. Because of docker-in-docker we were having to install this plugin on each run.

Would really appreciate a CDN, these rate limits probably don't trigger for anyone doing local development - you only install once. But in CI environments, you end up running installs much more frequently and can easily hit the rate limit if you have multiple projects running on the same agent.

cnunciato commented 8 months ago

Binaries for 0.10.2 and 0.11.1 have been published, and future releases should be published automatically.

$ pulumi plugin install resource synced-folder v0.11.1 --server https://get.pulumi.com/releases/plugins
[resource plugin synced-folder-0.11.1] installing
Downloading plugin: 45.80 MiB / 45.80 MiB [=========================] 100.00% 3s

$ pulumi plugin ls
NAME           KIND      VERSION  SIZE    INSTALLED      LAST USED
synced-folder  resource  0.11.1   353 MB  8 seconds ago  8 seconds ago