search

pulumi / pulumi-terraform-bridge

A library allowing providers built with the Terraform Plugin SDK to be bridged into Pulumi.
Apache License 2.0
188 stars 43 forks source link

terraform-provider-vantage blocked on numeric ID support #1198

Closed t0yv0 closed 1 week ago

t0yv0 commented 1 year ago

What happened?

@jaxxstorm reports an issue blocking terraform-provider-vantage. Similarly to https://github.com/pulumi/pulumi-terraform-bridge/issues/352 the bridge assumes ID field is a string so when TF defines a numeric ID the system runs into problems. Unlike the pkg/v3 bridge, PF is also more strict by default so workarounds to pretend the ID is a string do not apply. We need to make sure this scenario works naturally:

https://github.com/vantage-sh/terraform-provider-vantage/blob/main/vantage/aws_provider_resource.go#L25

Expected Behavior

users can bridge providers with resources defining the "ID" fields as numbers.

Steps to reproduce

See above.

Output of pulumi about

N/A

Additional context

pf/v0.11.1

Contributing

Vote on this issue by adding a 👍 reaction. To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

t0yv0 commented 1 year ago

Related: https://github.com/pulumi/pulumi-terraform-bridge/issues/352

guineveresaenger commented 7 months ago

Just ran into this for pulumi-dnsimple as well.