pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
194 stars 43 forks source link

Accept secrets #1506

Open iwahbe opened 11 months ago

iwahbe commented 11 months ago

Hello!

Issue details

Customizations such as https://github.com/pulumi/pulumi-gcp/issues/1316 require knowing what input fields are secret. To enable these kinds of customizations, we should support secrets in the bridge.

This is a prerequisite for implementing other secret strategies in the bridge, such as secret-by-value.

Affected area/feature

t0yv0 commented 11 months ago

This affects AWS as well and is fairly convoluted at the moment. I would request a design doc on this (can collab).

This is a prerequisite for other secret strategies, such as secret-by-value.

Not obviously true.

iwahbe commented 11 months ago

This affects AWS as well and is fairly convoluted at the moment. I would request a design doc on this (can collab).

I'd be happy to work with you on a design doc. This isn't a proposal, as much as a placeholder for one.

This is a prerequisite for other secret strategies, such as secret-by-value.

Not obviously true.

It is a prerequisite other strategies, when implemented in the bridge. The engine could implement these without the bridge supporting secrets.

t0yv0 commented 11 months ago

Awesome. Let's do a design here to consider a few options where we can go, also cover AWS issues and issues with secrets in Invoke and Configure.

t0yv0 commented 8 months ago

https://github.com/pulumi/pulumi-terraform-bridge/issues/1621 worth picking up soon-ish? I think this makes sense long-term for completeness but can be a bit time-consuming to thoroughly test. For now relying on the engine to discover and re-inject secrets continues to work mostly OK, and with https://github.com/pulumi/pulumi/pull/15032 we can simplify this a fair bit which brings us to the better place.

t0yv0 commented 7 months ago

Linking the related issues with AWS tagsAll causing pressure on bulk-encryption in https://github.com/pulumi/pulumi/issues/15498