search

pulumi / pulumi-terraform-bridge

A library allowing providers built with the Terraform Plugin SDK to be bridged into Pulumi.
Apache License 2.0
184 stars 42 forks source link

[tfshim/tfplugin5] Cleanup context passing and a test helper #2003

Closed iwahbe closed 1 month ago

iwahbe commented 1 month ago

I was looking at this code as part of https://github.com/pulumi/pulumi-terraform-bridge/pull/2001 and I did some cleanup, separated out into this PR.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.84%. Comparing base (a427483) to head (51ed5ec).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2003 +/- ## ========================================== - Coverage 60.85% 60.84% -0.02% ========================================== Files 332 332 Lines 44754 44754 ========================================== - Hits 27234 27229 -5 - Misses 15994 16000 +6 + Partials 1526 1525 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

t0yv0 commented 1 month ago

Could consider deprecating and dropping tfshim/tfplugin5 as we do not use it in prod I think, it can be out there as a reference for prior art but it was never fully validated by actual use.

VenelinMartinov commented 1 month ago

If unused, I'd be all for deleting it from master - git history can be a reference just as well as master.

iwahbe commented 1 month ago

I'd like to leave it in for now. It's test suite is still useful and I think we might want to plug it into #1973 in the near future.