search

pulumi / pulumi-terraform-bridge

A library allowing providers built with the Terraform Plugin SDK to be bridged into Pulumi.
Apache License 2.0
184 stars 42 forks source link

Refactor tfwrite #2011

Closed VenelinMartinov closed 1 month ago

VenelinMartinov commented 1 month ago

This PR refactors the tfwrite logic for determining blocks vs attributes to use the function in the plugin-sdk which does that, instead of duplicating the logic on our side.

This should be more correct.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 61.70213% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 60.93%. Comparing base (7b7804e) to head (e71ed9c). Report is 1 commits behind head on master.

Files Patch % Lines
pkg/tests/cross-tests/tfwrite.go 61.70% 17 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2011 +/- ## ========================================== - Coverage 61.02% 60.93% -0.10% ========================================== Files 333 333 Lines 44721 44793 +72 ========================================== + Hits 27292 27295 +3 - Misses 15906 15974 +68 - Partials 1523 1524 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.