Open VenelinMartinov opened 4 months ago
Attention: Patch coverage is 0%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 60.77%. Comparing base (
2094289
) to head (cf0801e
).
Files | Patch % | Lines |
---|---|---|
pkg/tests/cross-tests/rapid_tv_gen.go | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@VenelinMartinov Do we want to merge this?
I've meant to revisit but haven't managed to yet. If you are seeing the panics here then I'm happy to merge this until we find time to root-cause
I've meant to revisit but haven't managed to yet.
No problem.
If you are seeing the panics here then I'm happy to merge this until we find time to root-cause
I'm not sure what you mean here.
I'm not sure what you mean here.
Are you blocked on this PR getting merged or were you just revisiting old PRs?
I'm not sure what you mean here.
Are you blocked on this PR getting merged or were you just revisiting old PRs?
Just revisiting old PRs.
rapid wants us to always consume from the random bitstream but we don't do that when we generate empty collection values. This just adds some generators in those cases so that rapid doesn't panic.