Closed iwahbe closed 1 month ago
Attention: Patch coverage is 53.84615%
with 12 lines
in your changes are missing coverage. Please review.
Project coverage is 63.24%. Comparing base (
9cf2ede
) to head (875c5c0
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It's not entirely clear to me that this needs to be in an
internal
package.
I'm not sure what you mean. Are you suggesting that it shouldn't be a package or that it shouldn't be internal?
Is it not sufficient to export
Provider
(andProvider
only) if we have a newcheck
package?
We do export Provider
(and Provider
only), but we only export them for tfgen
. We don't want end users to be calling these functions. We don't have any backwards compatibility guarantees on names or signatures.
I see, you are saying end users should not be calling check.Provider()
at all either.
I don't have a particularly strong feeling here; I would've left it at tfgen.checkProvider
but usage wise internal
makes sense too. Feel free to resolve.
Waiting on API token limits to get to a green CI and merge.
This PR is best reviewed commit by commit:
checkProvider
. This ensures that every entry point can just callcheckProvider
. Previously we had two validation functions and we didn't always call both of them.checkProvider
and it's sub-functions into their own internal package. We do this to prevent directly calling the non-primary function.Fixes https://github.com/pulumi/pulumi-terraform-bridge/issues/2030