search

pulumi / pulumi-terraform-bridge

A library allowing Terraform providers to be bridged into Pulumi.
Apache License 2.0
194 stars 43 forks source link

remove max items one defaults hacks #2049

Closed VenelinMartinov closed 4 months ago

VenelinMartinov commented 4 months ago

This is a pure refactor.

Reverts the options added in https://github.com/pulumi/pulumi-terraform-bridge/pull/1725 as these were the wrong way to do the change.

https://github.com/pulumi/pulumi-terraform-bridge/pull/1971 should be the proper fix to the issues encountered there, now backed by cross-tests.

This should simplify the code around makeTerraformInputs a bit.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.21%. Comparing base (1f9028f) to head (38e62fc).

:exclamation: Current head 38e62fc differs from pull request most recent head 6b6de90

Please upload reports for the commit 6b6de90 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2049 +/- ## ========================================== + Coverage 61.39% 63.21% +1.82% ========================================== Files 334 333 -1 Lines 44950 37382 -7568 ========================================== - Hits 27595 23631 -3964 + Misses 15829 12224 -3605 - Partials 1526 1527 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.